Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved config for fragment types #424

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Improved config for fragment types #424

merged 3 commits into from
Jan 24, 2025

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Jan 6, 2025

Remove semicolon separated fragment type and use a list instead.

@GeorgWa GeorgWa requested a review from mschwoer January 6, 2025 13:43
Base automatically changed from simplify_config to development January 9, 2025 11:52
mschwoer
mschwoer approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/constants/default.yaml Outdated Show resolved Hide resolved
@mschwoer mschwoer mentioned this pull request Jan 9, 2025
Open
@mschwoer mschwoer deleted the branch main January 17, 2025 09:26
@mschwoer mschwoer closed this Jan 17, 2025
@mschwoer mschwoer reopened this Jan 17, 2025
@GeorgWa GeorgWa changed the base branch from development to main January 17, 2025 12:34
@GeorgWa GeorgWa merged commit abfefaf into main Jan 24, 2025
5 checks passed
@GeorgWa GeorgWa deleted the list-config branch January 24, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer approved these changes

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgWa @mschwoer